-
Notifications
You must be signed in to change notification settings - Fork 78
feat(server): Support removing tools, prompts and resources #85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
A PR to add support for removing tools, prompts, and resources from the SDK server. Key changes include new functions to remove a single or multiple items with appropriate capability checks and logging.
- Added removeTool and removeTools functions for tool removal.
- Added removePrompt and removePrompts functions for prompt removal.
- Added removeResource and removeResources functions for resource removal.
Files not reviewed (1)
- api/kotlin-sdk.api: Language not supported
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @134130, thanks for the PR.
Could you tell me the reason for the change? I'm not sure I understand the use case
Hi @e5l, sorry for my lack of description. The MCP is designed on the user's context. That is the reason why the client supports root API. For example:
Also, there is a tool-list changed notifications channel. Which means the MCP Server is designed as the tools(resources, prompts) can be changed anytime. So, there is no reason to restrict server providers from removing the tool, and that makes it difficult for me to make the rich MCP API for the users. |
That's a valid use case. If you want this use case to be fully supported, please consider writing a separate PR with documentation of it |
Motivation and Context
How Has This Been Tested?
Breaking Changes
Types of changes
Checklist
Additional context